[Sync EN] strlen, strstr, strcasecmp, strncasecmp#44
Open
lacatoire wants to merge 3 commits intophp:masterfrom
Open
[Sync EN] strlen, strstr, strcasecmp, strncasecmp#44lacatoire wants to merge 3 commits intophp:masterfrom
lacatoire wants to merge 3 commits intophp:masterfrom
Conversation
- strlen, strstr: add PHP_EOL between echoes in examples - strcasecmp, strncasecmp: use the shared &strings.comparison.return; entity for return values (replaces a free-form description, also fixes a stale '*' typo in strncasecmp)
…eturn The strings.comparison.return entity is not defined in doc-tr/language-snippets.ent, so referencing it would either break the build or leak English text. Restoring an inline Turkish description that matches the upstream EN content (uses '0'dan küçük/büyük bir değer' instead of the previous '-1'/'1', and corrects the stale '*' typo in strncasecmp by spelling out '0').
The TR strings/* family (strcmp, strncmp, strnatcmp) all use '<literal>-1</literal>; ... <literal>1</literal>; ... <literal>0</literal>'. Reverting strcasecmp/strncasecmp to that exact wording for consistency. The fix to the stale '*' typo in strncasecmp is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync of four widely-used string functions with upstream php/doc-en: